[PATCH] firmware: Fix comment after relocation completion
Anup Patel
apatel at ventanamicro.com
Sun Jun 28 01:42:34 PDT 2026
On Fri, Jun 26, 2026 at 7:56 AM Zong Li <zong.li at sifive.com> wrote:
>
> After relocation is done, the code is running from the load address,
> not the link address. Fix the comment to correctly reflect this.
>
> Signed-off-by: Zong Li <zong.li at sifive.com>
LGTM.
Reviewed-by: Anup Patel <anup at brainfault.org>
Applied this patch to the riscv/opensbi repo.
Thanks,
Anup
> ---
> firmware/fw_base.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/firmware/fw_base.S b/firmware/fw_base.S
> index 5d6540d7..0c5c65c1 100644
> --- a/firmware/fw_base.S
> +++ b/firmware/fw_base.S
> @@ -93,7 +93,7 @@ _sc_fail:
> addi t0, t0, (__SIZEOF_LONG__ * 3)
> blt t0, t1, 2b
> _relocate_done:
> - /* At this point we are running from link address */
> + /* At this point we are running from load address */
>
> /* Reset all registers except ra, a0, a1, a2, a3 and a4 for boot HART */
> li ra, 0
> --
> 2.43.7
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi
More information about the opensbi
mailing list