[PATCH 1/5] lib: sbi: Fix typos related to hart protection

Anup Patel anup.patel at oss.qualcomm.com
Fri Jul 24 07:53:55 PDT 2026


On Wed, Jul 22, 2026 at 4:26 PM Rahul Pathak
<rahul.pathak at oss.qualcomm.com> wrote:
>
> On Fri, Jul 17, 2026 at 1:15 PM Anup Patel <anup.patel at oss.qualcomm.com> wrote:
> >
> > The hart protection is incorrectly mentioned as hart isolation
> > at few places in sbi_init.c hence fix these typos.
> >
> > Signed-off-by: Anup Patel <anup.patel at oss.qualcomm.com>
> > ---
> >  lib/sbi/sbi_init.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c
> > index 658fe37f..4208db0b 100644
> > --- a/lib/sbi/sbi_init.c
> > +++ b/lib/sbi/sbi_init.c
> > @@ -428,12 +428,12 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
> >         }
> >
> >         /*
> > -        * Configure hart isolation at last because if SMEPMP is,
> > +        * Configure hart protection at last because if SMEPMP is,
> stray comma after "SMEPMP is"

Okay, I will update.

>
> >          * detected, M-mode access to the S/U space will be rescinded.
> >          */
> >         rc = sbi_hart_protection_configure(scratch);
> >         if (rc) {
> > -               sbi_printf("%s: hart isolation configure failed (error %d)\n",
> > +               sbi_printf("%s: hart protection configure failed (error %d)\n",
> >                            __func__, rc);
> >                 sbi_hart_hang();
> >         }
> > @@ -507,7 +507,7 @@ static void __noreturn init_warm_startup(struct sbi_scratch *scratch,
> >                 sbi_hart_hang();
> >
> >         /*
> > -        * Configure hart isolation at last because if SMEPMP is,
> > +        * Configure hart protection at last because if SMEPMP is,
> stray comma after "SMEPMP is"

Okay, I will update.

>
> >          * detected, M-mode access to the S/U space will be rescinded.
> >          */
> >         rc = sbi_hart_protection_configure(scratch);
> > --
> > 2.43.0
> >
>
> Only nits, otherwise looks good
>
> Reviewed-by: Rahul Pathak <rahul.pathak at oss.qualcomm.com>

Regards,
Anup



More information about the opensbi mailing list