[PATCH v2 3/5] lib: sbi: Removal unnecessary check dbtr_thishart_state_ptr

Himanshu Chauhan hchauhan at ventanamicro.com
Tue Apr 30 02:38:57 PDT 2024



On 23/04/24 20:27, Xiang W wrote:
> After getting hart_shmem_base, dbtr_thishart_state_ptr cannot be
> empty. So remove check code.
> 
> Signed-off-by: Xiang W <wxjstz at 126.com>
> ---
>   lib/sbi/sbi_dbtr.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/lib/sbi/sbi_dbtr.c b/lib/sbi/sbi_dbtr.c
> index ceff185..4093a82 100644
> --- a/lib/sbi/sbi_dbtr.c
> +++ b/lib/sbi/sbi_dbtr.c
> @@ -683,8 +683,6 @@ int sbi_dbtr_update_trig(unsigned long smode,
>   		return SBI_ERR_NO_SHMEM;
>   
>   	hs = dbtr_thishart_state_ptr();
> -	if (!hs)
> -		return SBI_ERR_FAILED;
>   
>   	for_each_set_bit_from(idx, &trig_mask, hs->total_trigs) {
>   		trig = INDEX_TO_TRIGGER(idx);

LGTM

Reviewed-by: Himanshu Chauhan <hchauhan at ventanamicro.com>

- Himanshu



More information about the opensbi mailing list