[PATCH 1/3] Makefile: clean auto-generated *.c files properly

Andrew Jones ajones at ventanamicro.com
Mon Apr 22 08:19:41 PDT 2024


On Mon, Apr 01, 2024 at 10:34:36PM +0100, Ivan Orlov wrote:
> Currently, `make clean` doesn't remove auto-generated .c files in the
> `build/` directory. It means that we don't have a reliable way of
> regenerating these files except from removing the `build/` directory
> manually.
> 
> Update the `clean` target in order to remove these files as well.
> 
> In the discussion of the "[PATCH v2 3/5] Makefile: clean '.c' files
> generated by carray", Andrew Jones <ajones at ventanamicro.com> suggested
> placing the auto-generated .c files into the `build/generated/` folder.
> However, I believe it may not be necessary as in fact all of the files
> in `build/` are auto-generated.

Since the Makefile enforces that the build dir is not the same as the
source dir and the only C files we currently generate are carray files,
then OK. I still think it would be nice to be more specific about what
we clean, though.

> 
> Signed-off-by: Ivan Orlov <ivan.orlov0322 at gmail.com>
> ---
>  Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index 680c19a..4519277 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -684,6 +684,8 @@ clean:
>  	$(CMD_PREFIX)find $(build_dir) -type f -name "*.bin" -exec rm -rf {} +
>  	$(if $(V), @echo " RM        $(build_dir)/*.dtb")
>  	$(CMD_PREFIX)find $(build_dir) -type f -name "*.dtb" -exec rm -rf {} +
> +	$(if $(V), @echo " RM        $(build_dir)/*.c")
> +	$(CMD_PREFIX)find $(build_dir) -type f -name "*.c" -exec rm -rf {} +
>  
>  # Rule for "make distclean"
>  .PHONY: distclean
> -- 
> 2.34.1
>

Reviewed-by: Andrew Jones <ajones at ventanamicro.com>



More information about the opensbi mailing list