[PATCH v3 3/8] lib: sbi_pmu: Reserve space for implementation specific firmware events

Andrew Jones ajones at ventanamicro.com
Thu Mar 9 01:16:53 PST 2023


On Thu, Mar 09, 2023 at 11:21:07AM +0530, Mayuresh Chitale wrote:
> We reserve space for SBI implementation specific custom firmware
> events which can be used by M-mode firmwares and HS-mode hypervisors
> for their own use. This reserved space is intentionally large to
> ensure that SBI implementation has enough space to accommodate
> platform specific firmware events as well.
> 
> Signed-off-by: Mayuresh Chitale <mchitale at ventanamicro.com>
> Reviewed-by: Atish Patra <atishp at rivosinc.com>
> ---
>  include/sbi/sbi_ecall_interface.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/sbi/sbi_ecall_interface.h b/include/sbi/sbi_ecall_interface.h
> index d448212..8d1cb97 100644
> --- a/include/sbi/sbi_ecall_interface.h
> +++ b/include/sbi/sbi_ecall_interface.h
> @@ -185,6 +185,17 @@ enum sbi_pmu_fw_event_code_id {
>  	SBI_PMU_FW_HFENCE_VVMA_ASID_SENT = 20,
>  	SBI_PMU_FW_HFENCE_VVMA_ASID_RCVD = 21,
>  	SBI_PMU_FW_MAX,
> +	/*
> +	 * Event codes 22 to 255 are reserved for future use.
> +	 * Event codes 256 to 65534 are reserved for SBI implementation
> +	 * specific custom firmware events.
> +	 */
> +	SBI_PMU_FW_RESERVED_MAX = 0xFFFE,
> +	/*
> +	* Event code 0xFFFF is used for platform specific firmware
> +	* events where the event data contains any event specific information.
> +	*/

The above three lines need to be spaced over one space. And, then, "the
stars will align", which should improve our luck!

Thanks,
drew

> +	SBI_PMU_FW_PLATFORM = 0xFFFF,
>  };
>  
>  /** SBI PMU event idx type */
> -- 
> 2.34.1
> 
> 
> -- 
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi



More information about the opensbi mailing list