[PATCH] lib: sbi: Simplify the initialization of root_hmask in sbi_domain_init

[Anup Patel]

On Mon, Dec 11, 2023 at 7:00 PM Xiang W <wxjstz at 126.com> wrote:
>
> The original code has multiple conversions between hartid and
> hartindex. Can call sbi_hartmask_set_hartindex directly to
> avoid conversion.
>
> Signed-off-by: Xiang W <wxjstz at 126.com>

LGTM.

Reviewed-by: Anup Patel <anup at brainfault.org>

Applied this patch to the riscv/opensbi repo.

Thanks,
Anup


> ---
>  lib/sbi/sbi_domain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/sbi/sbi_domain.c b/lib/sbi/sbi_domain.c
> index 88d25de..4e9f742 100644
> --- a/lib/sbi/sbi_domain.c
> +++ b/lib/sbi/sbi_domain.c
> @@ -815,8 +815,7 @@ int sbi_domain_init(struct sbi_scratch *scratch, u32 cold_hartid)
>
>         /* Root domain possible and assigned HARTs */
>         for (i = 0; i < plat->hart_count; i++)
> -               sbi_hartmask_set_hartid(sbi_hartindex_to_hartid(i),
> -                                       root_hmask);
> +               sbi_hartmask_set_hartindex(i, root_hmask);
>
>         /* Finally register the root domain */
>         rc = sbi_domain_register(&root, root_hmask);
> --
> 2.42.0
>
>
> --
> opensbi mailing list
> opensbi at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/opensbi