[PATCH v5 1/3] lib: sbi: move sbi_boot_print_general()

[Anup Patel]

On Sat, Nov 6, 2021 at 3:24 PM Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> Moving the sbi_boot_print_general() call after the
> sbi_platform_final_init() call allows to print devices initialized in the
> latter.
>
> To keep the overall print sequence the same also move
> sbi_boot_print_domains().
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>

Looks good to me.

Reviewed-by: Anup Patel <anup.patel at wdc.com>

Regards,
Anup

> ---
> v5:
>         move sbi_boot_print_domains() too
> v4:
>         no change
> v3:
>         no change
> v2:
>         new patch
> ---
>  lib/sbi/sbi_init.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/lib/sbi/sbi_init.c b/lib/sbi/sbi_init.c
> index 843659e..765c7b6 100644
> --- a/lib/sbi/sbi_init.c
> +++ b/lib/sbi/sbi_init.c
> @@ -293,8 +293,6 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
>                 sbi_hart_hang();
>         }
>
> -       sbi_boot_print_general(scratch);
> -
>         /*
>          * Note: Finalize domains after HSM initialization so that we
>          * can startup non-root domains.
> @@ -308,8 +306,6 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
>                 sbi_hart_hang();
>         }
>
> -       sbi_boot_print_domains(scratch);
> -
>         rc = sbi_hart_pmp_configure(scratch);
>         if (rc) {
>                 sbi_printf("%s: PMP configure failed (error %d)\n",
> @@ -328,6 +324,10 @@ static void __noreturn init_coldboot(struct sbi_scratch *scratch, u32 hartid)
>                 sbi_hart_hang();
>         }
>
> +       sbi_boot_print_general(scratch);
> +
> +       sbi_boot_print_domains(scratch);
> +
>         sbi_boot_print_hart(scratch, hartid);
>
>         wake_coldboot_harts(scratch, hartid);
> --
> 2.32.0
>