Possible bug in icmp-ping.c

[Karl O. Pinc]

Hi Paul,

On Thu, 5 Nov 2026 11:41:05 +0100
Paul Courbis de Bridiers de Villemor <paul at courbis.fr> wrote:

> In icmp-ping.c I see this code :

<snip>

> I think the closing parenthesis
> should be just after sizeof(*addr1) :

<snip>

> But I'm not an expert

I'm not an expert either.  I am under the impression
that the best way to see this addressed is
to file an issue at:

https://gitlab.com/openconnect/openconnect

This prevents your email from getting lost.

Even better, since you have a fix, file a
merge request.  Think of it -- you can be
famous and have your name in the changelog!
(If there's some sort of test harness in
place involving the code you're changing,
a test would be good too.)

Regards,

Karl <kop at karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein