[PATCH] *.sh: Fix kornsh-ism test(1) invocations

Daniel Lenski dlenski at gmail.com
Wed Sep 14 17:03:00 PDT 2022


On Wed, Sep 14, 2022 at 5:30 AM Bernhard Reutner-Fischer
<rep.dot.nop at gmail.com> wrote:
>
> s/==/=/g
> s/]]/]/g
> s/\[\[/[/g
>
> The POSIXly correct shorthand of test(1) is [, not [[
> and string comparison is POSIXly correct =, not ==.

Do note that all three of these scripts are explicitly intended+tested
*only* to run under Bash…

    $ head -n1 android/fetch.sh trojans/csd-*.sh
    ==> android/fetch.sh <==
    #!/bin/bash

    ==> trojans/csd-post.sh <==
    #!/bin/bash

    ==> trojans/csd-wrapper.sh <==
    #!/bin/bash

Is there some specific environment where your modifications make them
work with a "plain" POSIX sh, where they didn't previously work
correctly?



More information about the openconnect-devel mailing list