[PATCH 01/10] Unfortunately, xmlNodeGetContent can't be avoided
Daniel Lenski
dlenski at gmail.com
Tue Jan 9 00:01:15 PST 2018
I tested it, and see here: https://stackoverflow.com/a/10441292/20789
Signed-off-by: Daniel Lenski <dlenski at gmail.com>
---
auth-globalprotect.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/auth-globalprotect.c b/auth-globalprotect.c
index 1e7c854..0c151fe 100644
--- a/auth-globalprotect.c
+++ b/auth-globalprotect.c
@@ -127,7 +127,6 @@ static int parse_login_xml(struct openconnect_info *vpninfo, xmlNode *xml_node)
if (xml_node && !xmlnode_is_named(xml_node, "argument"))
goto err_out;
else if (xml_node) {
- /* XX: Could we just use xml_node->content here? */
value = (char *)xmlNodeGetContent(xml_node);
if (value && (!value[0] || !strcmp(value, "(null)") || !strcmp(value, "-1"))) {
free(value);
--
2.7.4
More information about the openconnect-devel
mailing list