[PATCH 00/10] GPST patches, trying again

[Daniel Lenski]

On Tue, Feb 27, 2018 at 10:29 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
>
>
>
> On Tue, 2018-01-09 at 00:01 -0800, Daniel Lenski wrote:
> > Here is a new, cleaned-up set of GlobalProtect patches.
> >
> > These apply and build cleanly on top of the David's gpst
> > (currently at 82d4430da8f593109f90637fafb799a41a937330,
> > http://git.infradead.org/users/dwmw2/openconnect.git/shortlog/refs/heads/gpst)
> > *after* merging the upstream master
> > (currently at fdaba772b27d66f92a3d035d18d7b4e15292f6b9,
> > http://git.infradead.org/users/dwmw2/openconnect.git/shortlog).
> >
> > These patches add three new feature not yet included in the gpst
> > branch:
> >
> > 1. HIP report spoofing/submission (~ GP version of ~CSD, ~TNCC)
> > 2. Tunnel-based rekey
> > 3. Replay protection with GlobalProtect ESP (just sets the appropriate flag :-D)
> >
> > They also include a lot of cleanup and bug fixing:
>
> I don't even remember what my 'gpst' branch was. Did I just pull in an
> early round of your patches and then do some fixes and /* XXX: */
> heckling on top? I'm not sure we need to preserve any of that stuff in
> its original form.

I believe that is pretty much right.

> I've pulled in your patches (up to 14/10) on top. What's next?
> I'd like at least to fix the win32 builds,

Definitely. Also please apply the patch I just submitted, which fixes
a dumb, rare bit-shifting bug introduced in one of my previous
patches.

> and then are we going to refactor
> them into a more readable patch series for review?

The problem is that at this point the GP patches are interleaved with
non-GP patches. Do you want me to refactor *all* the changes to add GP
support into a more readable patch series on top of your master
branch?

> Do you think it's going to pass review now? :)

Well… I've gone through and tried to fix memory handling bugs, dodgy
string handling, add comments, standardize the code formatting, ensure
that it will work with the NM plugin… and generally take a critical
eye towards the code style. I'm not sure what else, if anything, you
think needs another review but I'll try to address anything that comes
up promptly.

> I'd love to finally get this merged and do a new release...

Yes indeed. I know some downstream projects like Ľubomír Carik's
Windows openconnect-gui are awaiting a merge of this as well.

Thanks,
Dan