[PATCH 1/3] Solve few fall-trough warnings

Ľubomír Carik lubomir.carik at gmail.com
Thu Feb 22 12:29:02 PST 2018


thanks, so we can use e.g. '__attribute__((fallthrough))' statement;
looks ok? (modified patch attached)

2018-02-22 11:10 GMT+01:00 David Woodhouse <dwmw2 at infradead.org>:
> On Thu, 2018-02-22 at 00:12 +0100, Ľubomír Carik wrote:
>> Signed-off-by: Ľubomír Carik <Lubomir.Carik at gmail.com>
>> ---
>>  main.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/main.c b/main.c
>> index 935147f..86ba8cb 100644
>> --- a/main.c
>> +++ b/main.c
>> @@ -610,6 +610,7 @@ static void print_build_opts(void)
>>       case 2:
>>               printf("%sHOTP software token", sep);
>>               sep = comma;
>> +             break;
>>       case 1:
>>               printf("%sTOTP software token", sep);
>>               sep = comma;
>
> That one really should fall through. If it returns 1 that means we have
> only TOTP support; if it returns 2 we have both.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Solve-few-fall-trough-warnings.patch
Type: application/octet-stream
Size: 917 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20180222/d383792d/attachment.obj>


More information about the openconnect-devel mailing list