[PATCH 3/3] Require administrator privileges (UAC)

[Ľubomír Carik]

2018-02-22 0:27 GMT+01:00  <Rondom at rondom.de>:
> On 22/02/18 00:12, Ľubomír Carik wrote:
>> The application requires higher run privileges to be able modify
>> network settings. With this change, there is no need to start
>> the tool explicitly in console with administrator rights.
>
> I have not tested this patch (and I am no Windows expert, either)... so take the following with a pinch of salt.
>
> Does this improve the user-experience? The last time I checked, requiring admin privileges this way led to the following behaviour:
>
> 1) User run command from unprivileged command-prompt
> 2) User gets UAC-prompt, confirms elevation of privileges
> 3) New CMD-window appears, ouput scrolls by
> 4) New CMD-window closes once command is finished
> 5) User returns to prompt in original unprivileged command-prompt without any output visible there.
>
> But maybe that does not matter that much and it does indeed improve the user-experience because the user gets asked for credentials anyways, so the new window stays open. Still any error-messages would be invisible to the user. Or maybe the behaviour is not like I described above...
>

yes, that's true with new elevated cmd-window...

On other side,
1. it prevents the scenario that user try connect in unprivileged mode
what end as successful connection,
but without working routing stuff etc.
2. it allow us to create desktop shortcut with gateway-name as suffix
to command (in this case we will get only one! connection cmd-shell)

May be, I have to add something to "Press any key to continue..." on
the end of main fn (windows-only)...

>
> _______________________________________________
> openconnect-devel mailing list
> openconnect-devel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/openconnect-devel