[PATCH 1/4] Support routes with different devs and gateways

Gernot Hillier gernot.hillier at siemens.com
Tue Oct 17 05:35:23 PDT 2017


Am 17.10.2017 um 12:12 schrieb David Woodhouse:
> On Tue, 2017-10-17 at 10:54 +0200, Gernot Hillier wrote:
>> Ah, and BTW, these are global, not local variables. Something which made
>> me scratching my head for quite some time when looking for a bug in the
>> /sbin/route case with re-enabled route cleanup (my patch no. 4).
>> set_network_route used to call del_network_route which overwrote the
>> used global variables...
> 
> Yeah, that occurred to me as I was typing the word "local". Perhaps
> they *should* really be "local" variables.

Hmm, I just implemented this and was about to submit a patch - but
finally noticed too late that we specify /bin/sh as interpreter. :-(

It seems that ash and dash support "local" keyword, but sh as specified
in
http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html
seems to lack this feature. :-(

Suggestions?

-- 
Gernot

Siemens AG, Corporate Competence Center Embedded Linux




More information about the openconnect-devel mailing list