[PATCH v2 0/3] Support for Pulse's split-exclude routes

[Gernot Hillier]

Hi there!

On Oct, 30th 15:04 Gernot Hillier wrote:
> OpenConnect already sets the according environment variables when the Pulse
> gateway sends "split-exclude" routes, so we only need to handle them
> in vpnc-script.

Might I ask for your review/feedback regarding these patches?

> Patch history:
> 
> Original series: 
> - assumed split-exclude targets and VPN gateway are reachable via the same uplink
> v2:
> - re-use current routing information for the "ip route" case for split-exclude
>   routes, only guess about correct uplink for /sbin/route case
> - patches are now independent of each other, but I chose to leave them in the
>   same series for better comparability.
> - throw away untested IPv6 code

Can you please let me know whether you prefer the v1 approach (see
http://lists.infradead.org/pipermail/openconnect-devel/2017-October/004530.html)
or v2 approach? And what I should/could still improve before considering
a merge of all or some of them?

Thanks in advance!

(Having this feature upstream would really help my Siemens Linux
colleagues worldwide so we can just use the upstream version in
future... :) )

-- 
Kind regards,

Gernot Hillier
Siemens AG, Corporate Competence Center Embedded Linux