[PATCH] write CISCO_SPLIT_INC in order

[Daniel Lenski]

On Fri, Jul 21, 2017 at 10:15 AM, Kevin Cernekee <cernekee at gmail.com> wrote:
> On Mon, Jul 10, 2017 at 3:44 PM, Corey Hickey <bugfood-ml at fatooh.org> wrote:
>> The linked list implementation results in routes being queued in
>> reverse of the order in which they were received. So, when dequeuing
>> them, write to the buffer backwards.
>
> Unfortunately it is not clear to me which parameter you would like to
> reorder: search domains (from the GitHub bug), split DNS (from the
> patch), or included routes (from the subject line)?
>
> Search domains are sensitive to ordering, so that makes the most sense
> to me.  AIUI routing should use the longest prefix match + metric; and
> split DNS should not be sensitive to ordering since it is a whitelist.

I believe that search domains are the intended case that needs fixing.

It seems that OpenConnect's current behavior is to send *all of these
lists* to the vpnc-script in the opposite order from which they are
sent by the VPN gateway, and that Corey's patch will — if nothing else
— make script debugging a bit more intuitive by showing them all in
the same order in which OpenConnect receives them from the server.

Thanks,
Dan