OpenConnect 7.07 fails to build with LibreSSL

[David Woodhouse]

On Wed, 2017-04-26 at 15:22 +0200, Piotr Kubaj wrote:
> Sure, it's attached.
> 
> On 17-04-25 15:26:36, David Woodhouse wrote:
> > 
> > On Tue, 2017-04-25 at 14:00 +0200, Piotr Kubaj wrote:
> > > 
> > > 
> > > 
> > > So, OpenConnect 7.08 (I've verified this problem is also present in
> > > OpenConnect's master branch) is once again broken with LibreSSL
> > > (2.5.1 and higher). This patch fixes issues https://github.com/gentoo
> > > /libressl/blob/master/net-vpn/openconnect/files/openconnect-7.08-
> > > libressl251.patch while not breaking older releases. Could you merge
> > > it?
> > Thanks. Can I have a commit message explaining the fix, and a signed-
> > off-by please?

Thanks... but that's still not really explaining the fix. What changed
in LibreSSL? Why are we using enc_read_ctx instead of enc_write_ctx
now; why is that OK? Was it a bug before? Is it guaranteed to keep
working now or did the read context just not change *yet*? What commit
in LibreSSL changed this... ?

All of which I can work out for myself given enough time and
motivation, but it's supposed to be there in the commit message so I
don't have to... :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 4938 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20170426/f0274708/attachment.bin>