[PATCH] Problem: [OSX] libpcsclite is listed as required library in openconnect.pc.

[David Woodhouse]

On Sun, 2016-09-25 at 16:58 +0200, Björn Ketelaars wrote:
> When compiling under OSX, openconnect.pc has libpcsclite listed as dependency.
> Unfortunately there is no such library under OSX as OSX's own framework is
> used. This is kind of a nuisance as other projects (e.g. openconnect-gui) are
> unable to build as pkg-config is unable to find all required libraries.
> 
> Workarounds:
> 1.) use --without-libpcsclite which means no Yubikey support.
> 2.) Install a package manager (e.g. Homebrew) and install pcsc-lite as
>   package. As a result suitable libraries are installed.
> 
> Preferred solution:
> An alteration to configure.ac. Check if LIBPCSCLITE_LIBS (defined on line 62)
> is altered when compiling on OSX. If so, act accordingly.

Thanks for the report and the patch. In fact I've fixed it slightly
differently — we don't want 'pcsclite' on the Requires.private line of
openconnect.pc, but we *do* want the appropriate library inclusions in
Libs.private.

Also, I've taken the opportunity to ditch the horrid trick where we set
LIBPCSCLITE_CFLAGS=" " to implicitly override the pkg-config check.
Instead we can avoid it explicitly, which is somewhat nicer.

We also need to do the same thing on Windows.

-- 
dwmw2


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5760 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20160925/b29c78cf/attachment.bin>