Issue with CISCO_DEF_DOMAIN and invalid resolv.conf

[Raghavendra Prabhu]

Actually, I see a fix sent two days back,
http://lists.infradead.org/pipermail/openconnect-devel/2016-August/003819.html

I believe that should fix it even though it picks only the first one
in domain list.

(Rest of the domains except the first can be probably be skipped since
resolv.conf states "If more than one instance of these keywords is
present, the last instance wins.").

Sorry for the noise.

Thanks.


On Sun, Aug 7, 2016 at 4:03 PM, Raghavendra Prabhu <me at rdprabhu.com> wrote:
> Greetings,
>
> I noticed that in 7.07 release of openconnect the issue with DNS
> domains has been fixed.
>
> commit 4aad4c877841fd63acd273d5d84231ca8fca53f4
>  Author: David Woodhouse <David.Woodhouse at intel.com>
>  Date:   Thu Aug 6 11:34:01 2015 +0100
>
>      Strip commas from DNS search paths
>
>      Based on a patch from Joe Barnett <jbarnett at marinsoftware.com>
>
>      Signed-off-by: David Woodhouse <David.Woodhouse at intel.com>
>
> '<li>Fix handling of multiple DNS search domains with Network Connect.</li>'
>
>
> Thanks for this. However, this still generates invalid resolv.conf
>
>       "nslookup: parse of /etc/resolv.conf failed"
>
> This is because,   for multiple domains,  it generates like 'domain X
> Y Z'  which is not correct as per resolv.conf(5).  I believe it needs
> to be one per line: 'domain X' 'domain Y' .. (parsing logic here:
> http://ftp.isc.org/isc/bind9/9.9.0rc1/bind-9.9.0rc1/lib/lwres/lwconfig.c)
>
> While this can be fixed in vpnc script (with some sed), I was
> wondering if this needs to be fixed in code. Also, may be rename
> CISCO_DEF_DOMAIN to CISCO_DEF_DOMAINS so that scripts are aware that
> there may be more than one.
>
> Thanks for the fix.
>
> Regards,
> --
> Raghavendra
> GPG Id : 0xD72BE977
> wnohang.net