[PATCH 1/2] Added support for HTTP authentication in the CSTP channel.

David Woodhouse dwmw2 at infradead.org
Fri Feb 20 07:19:14 PST 2015


On Fri, 2015-02-20 at 14:05 +0100, Nikos Mavrogiannopoulos wrote:
> 
> +
> +       if (auth_states == vpninfo->http_auth)
> +               proxy = 0;
> +       else
> +               proxy = 1;


I toyed with inferring the 'proxy' bit from the address of the auth
state. Something like

#define IS_PROXY_AUTH(vpninfo, auth_state) ((auth_state) >=
(vpninfo)->proxy_auth)

I think you're probably right to do it, and we should do it consistently
(letting us drop the separate 'proxy' argument to a whole bunch of
functions).


-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20150220/3b72c8e8/attachment.bin>


More information about the openconnect-devel mailing list