[PATCH 2/4] CSD: add commandline flag to prevent downloading the trojan

Antonio Borneo borneo.antonio at gmail.com
Sun Dec 6 23:32:49 PST 2015


On Mon, Dec 7, 2015 at 3:58 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
> On Sun, 2015-12-06 at 16:21 +0800, Antonio Borneo wrote:
>> Some misconfigured server provide the URI of the trojan but miss
>> the binary.
>> The new commandline flag "--csd-skip-download" is used to ignore
>> the broken URI.
>>
>> Signed-off-by: Antonio Borneo <borneo.antonio at gmail.com>
>
> Doesn't this one need adding to the libopenconnect API too?
>

You are right, I miss it !
I should modify the prototype of openconnect_setup_csd() by adding a
parameter skip_download, then propagate the change and set new API
5.4.

So, my question returns in a different way. What is the preferred option:
- new API 5.4 (forcing update for every user of libopenconnect)
- same API but if wrapper is specified then wrapper is resposible to
download the trojan blog (only who already uses a wrapper should care
of)
?

Best Regards
Antonio



More information about the openconnect-devel mailing list