[GIT PULL] Documentation updates; change SIGHUP behavior

[David Woodhouse]

On Sat, 2014-05-10 at 14:48 -0700, Kevin Cernekee wrote:
> ----------------------------------------------------------------
> Kevin Cernekee (3):
>       www: Update changelog

Thanks.

>       Update man page with information on SIGUSR1/SIGUSR2 usage

Hm. Do we really want to admit to that and make it part of the
documented interface? It was vaguely useful as a test hack a long time
ago but is it still worth having?

>       main: Make SIGHUP force a reconnection

Hm. That isn't a wonderfully backward-compatible change. If you send
SIGHUP to an existing openconnect process, it's going to kill the
connection and exit.

I wonder if we should continue to use both SIGHUP and SIGINT for
actually making it *disconnect*, either with a logout packet
(terminating the session so the cookie can't be re-used) or without one.
And since NetworkManager-openconnect currently uses SIGINT for the
disconnect-and-logoff action, I suppose we'd use SIGHUP for just
disconnecting. (Making NM-openconnect cope with re-using a cookie and
automatically reconnecting to the VPN when it manages to reconnect to
the local network is on my ever-growing TODO list...)

If we use USR2 for your new capability to force an immediate reconnect,
then that's going to do the right thing (nothing) on old versions of
openconnect. And then we don't end up putting hacks into the tools which
*use* that facility, to try to work out which version they're running.

You end up with the following signal behaviour:
 SIGINT: Disconnect and logoff, run vpnc-script accordingly
 SIGHUP: Disconnect and run vpnc-script (cookie can be re-used)
 SIGTERM: Just die. Disconnect without logoff, no vpnc-script
 SIGUSR2: Reconnect to server immediately as if DPD triggered.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse at intel.com                              Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140521/646f0206/attachment.bin>