[PATCH V2 nm-openconnect 2/3] auth-dialog: Add support for NEWGROUP

[Kevin Cernekee]

On Wed, Feb 19, 2014 at 3:55 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
>> +static gboolean set_initial_authgroup (auth_ui_data *ui_data, struct oc_auth_form *form)
>> +{
>> +     struct oc_form_opt *opt;
>> +     char *authgroup_field = AUTHGROUP_FIELD(form);
>> +
>> +     if (!NEWGROUP_SUPPORTED || ui_data->group_set || authgroup_field)
>> +             return FALSE;
>
> Hm, shouldn't that final condition have been "|| !authgroup_field" ?

Yes.  This was correct in V1 of the patch; looks like I goofed when I
added "char *authgroup_field" in V2.

> And of course it's form->authgroup_opt now. After fixing that, I still
> see it dying thus when I change groups:
>
> ==4609== Invalid read of size 8
> ==4609==    at 0x3380816EC0: g_object_notify (gobject.c:1162)
> ==4609==    by 0x3390D09F54: gtk_combo_box_set_active_internal (gtkcombobox.c:4397)
> ==4609==    by 0x3390D0C5AD: gtk_combo_box_set_active_iter (gtkcombobox.c:4454)

I never saw these errors... I'm assuming you saw a crash when running
it normally, and then fired up valgrind to debug?