RFC: [PATCH] vpnc-script: split disconnect and destroy

[Antonio Borneo]

Hi David,

I'm reworking a patch I have received for vpnc
http://lists.unix-ag.uni-kl.de/pipermail/vpnc-devel/2013-December/004037.html
in a set of new patches that I'm going to apply soon.

The key point is the split, in vpnc-script, of do_disconnect()
by creating a new do_destroy().
I have isolated this part in the patch in attachment.

For backward compatibility I kept the original behavior for
reason=disconnect, but I consider this name as incorrect and
obsolete so added synonym reason=disconnect_destroy.
Beside it I have added reason disconnect_only and destroy that
implement separately the two parts of disconnect_destroy.

Today different distributions take vpnc-script either from vpnc or
from your git repository.
Committing this patch as first in both vpnc and your repository
should be fine to avoid issues whatever packaging mix is used.

Before committing this and the other patches in vpnc I want be
sure you agree to apply this one in your repository too.

Please notice that destroy_tun_device() has code for *BSD only.
If we suppose that on these OS the packages are built with proper
dependencies, we can be more aggressive with a cleaner patch
that introduces only the reason destroy.
In this case reason destroy have to be called independently by
openconnect and vpnc.

Best Regards,
Antonio
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vpnc-script-split-disconnect-and-destroy.patch
Type: text/x-patch
Size: 2528 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20140216/4c4363c1/attachment-0001.bin>