Windows support

[Nikos Mavrogiannopoulos]

On Tue, Feb 11, 2014 at 10:09 AM, David Woodhouse <dwmw2 at infradead.org> wrote:
>> Yes, this is how errno is interpreted in windows:
>> https://gitorious.org/gnutls/gnutls/source/505540944f1dd6a655a691714aed6d54ea7671fa:lib/system.c#L69
> Um,... if that's all handled in GnuTLS already, why do we even bother
> with overriding the pull/push/errno functions for OpenConnect? Couldn't
> I just strip that bit out?

The errno you can strip out. The recv et al, only if you compile with
a gnutls version that doesn't have the bug with gnulib replacement
functions (I think that's 3.2.9, or 3.1.19 and later).

> Btw, do you have reason to believe that Windows' putenv() takes a *copy*
> of the string? The Linux man page for putenv is very clear that it'll
> use the string in place and using an auto variable for it is very wrong.
> Was that an oversight on your part, or do you know something I don't?

No reason, it looks like a bug.

regards,
Nikos