[PATCH 3/3] main: Annotate format string args on new *_utf8 functions

David Woodhouse dwmw2 at infradead.org
Sun Dec 7 11:12:49 PST 2014


On Sat, 2014-12-06 at 23:01 -0800, Kevin Cernekee wrote:
> The new charset translation functions need to use caller-supplied format
> strings; this change corrects the following warnings:
> 
>       CC       openconnect-main.o
>     main.c:422:22: warning: format string is not a string literal
>           [-Wformat-nonliteral]
>                     return vfprintf(f, fmt, args);
>                                        ^~~
>     main.c:424:29: warning: format string is not a string literal
>           [-Wformat-nonliteral]
>             ret = vasprintf(&utf8_str, fmt, args);
>                                        ^~~


Hm, I could have sworn we couldn't shut it up because of
http://llvm.org/bugs/show_bug.cgi?id=18982

Perhaps I was just being entirely dim. Such is increasingly common these
days.

Applied, and fixed another stupid bug in the Windows code that it
immediately highlighted. Thanks.

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5745 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20141207/de8a4f5d/attachment-0001.bin>


More information about the openconnect-devel mailing list