[PATCH 4/6] added openconnect_strdup()

[Nikos Mavrogiannopoulos]

On Tue, Aug 26, 2014 at 4:40 PM, David Woodhouse <dwmw2 at infradead.org> wrote:
>> I've tried to implement that, and the tricky part is the auth form
>> processing. There the openconnect_strdup() has a clear advantage. It
>> is much simpler. Without it, the changes required become quite
>> complicated.
> Adding an openconnect_set_form_field() which does the strdup() should
> resolve that fairly simply shouldn't it?

So you mean to keep openconnect_strdup() and rename it to
openconnect_set_form_field()? If combined with your earlier proposal
to change ABI and have the main functions clean of any allocation it
would be pretty ok. Otherwise I think that the whole thing is becoming
complex. Some functions would require the strdup() (whatever its
name), and some others will free your data and strdup it internally.

regards,
Nikos