win32 related patches

Nikos Mavrogiannopoulos nmav at gnutls.org
Sat Aug 23 08:51:19 PDT 2014


On Fri, 2014-08-22 at 12:35 -0500, David Woodhouse wrote:
> > I don't think createprocess() can handle scripts, that's the reason I
> > got through cmd.exe. Anyway that patch is now quite improved.
> It can't handle scripts, but surely it can use cscript.exe instead of
> cmd.exe ?

Could be I don't know. I'll try next week.

> For the second patch... I'm not sure we should be polluting the global
> namespace on POSIX systems with that '#define SOCKET int'. Can we do
> something like
> #ifdef _WIN32
> SOCKET
> #else
> int
> #endif
> openconnect_setup_cmd_pipe(struct openconnect_info *vpninfo);

Ok. I'll send a new patch set next week. There is a crash that I cannot
figure, which I suspect it is because of a different malloc()/free()
combination being used in openconnect and to the caller application. 

regards,
Nikos





More information about the openconnect-devel mailing list