Patch against xml.c -- grab some more fields from the xml config file

[Jonas Kölker]

> > I've been monkeying a bit with xml.c, such that I can use openconnect
> > non-interactively, i.e. such that it reads all the input I'd otherwise have to
> > type in manually from the xml config file.
> Hrm, the XML config file is Cisco's invention
Ah, I didn't know.

> does it normally support the AuthGroup, UserName and PassWord options?
I don't know.

> I'm reluctant to add our own 'speshul' options in the XML file, especially
> since the XML file is normally downloaded from the server.
Good call.

> The three options you've added can all be passed on the command line (or
> stdin, for the password), so you can have a non-interactive openconnect
> even without changing the XML file.
Ah, cool.  Thanks.

No need for the patch, then.
 
> > In the process, I redecorated a few loops: "if(x) { ... }" became "if (!x)
> > continue; ...", such that the indentation doesn't as deep---IMO, it makes the
> > code easier to read.
> Yeah, that's a nice cleanup; thanks.
... except maybe for the cleaning-up and abstracting-away parts.

-- 
Jonas Kölker <jonaskoelker at gnu.org> <URL:http://jonaskoelker.ignorelist.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/openconnect-devel/attachments/20100225/4aea4506/attachment.sig>