[PATCH 08/14] Add ngnfs_dir_get_dirent() and debugfs lookup command

[Valerie Aurora]

On Sat, Mar 1, 2025 at 12:17 AM Zach Brown <zab at zabbo.net> wrote:
>
> I don't think lookup/get_dirent should include the name with the dirent
> it returns.  We only return the dirent if the name matches so they
> already have it.  And this would get rid of the layers of duplicate
> allocation and copies of the name.  We just have to make the API clear
> that you're only getting the dirent struct without the name.

Fixed, thank you!

> > +     init_dirent_key(&op->key, da->hash);
> > +     init_dirent_key(&op->last, da->hash | NGNFS_DIRENT_COLL_BIT);
>
> Are these two keys used?  I think they were replaced by the on-stack
> keys in lookup_iter() (which should maybe be called something like
> lookup_hash?).

Also fixed, thanks again!

Valerie