[PATCH 05/14] Add support for dtype

Zach Brown zab at zabbo.net
Mon Mar 3 10:02:46 PST 2025


On Mon, Mar 03, 2025 at 06:02:24PM +0100, Valerie Aurora wrote:
> On Fri, Feb 28, 2025 at 11:31 PM Zach Brown <zab at zabbo.net> wrote:

> > I had missed that da->dtype is the actual vfs dtype, not persistent
> > ngnfs enum, so it makes sense to use the linux helper.  Maybe we'll want
> > to tighten up the names to make the distinction clear, but it's fine for
> > now.
> 
> Thanks! I agree with changing the names, there are three kinds of
> dtypes (VFS, in-memory, on-disk) and I got the conversion wrong
> multiple times while writing these. Do you have any thoughts on a
> better scheme? As you know, I'm terrible at naming things. :)

I don't think that I do :(.  I, too, am just pants at naming things.

I guess I'd throw up my hands and be tediously literal: abi_dtype,
dtype, pers_dtype ?

- z



More information about the ngnfs-devel mailing list