[PATCH 00/20] Basic file and xattr operations [v2]
Zach Brown
zab at zabbo.net
Wed Jun 18 15:30:36 PDT 2025
On Thu, Jun 12, 2025 at 10:10:52PM +0200, Valerie Aurora wrote:
> This is a respin of the last patch series adding basic file and xatter
> operations, with the major additions of:
>
> * btree verification functions
> * implementation of btree replace_item()
> * fix serious destination/target confusion bug in rename()
>
> As usual, the uncontroversial bug fixes and tweaks are earlier in the
> patch series, and the larger, more complex, or more recent patches are
> later. This series implements all previous review comments; if a
> suggested change isn't in here, it's a mistake.
This is fantastic work, thanks for sending it. I merged all these
commits. The only change I made was to split the lk/ header additions
that were in the commit that added file data block tracking.
There were some things I'd have done differently here or there, but
nothing earth shattering. I'll respond to a few of the commits with
some thoughts for discussion's sake.
I also merged the commits I had pending that give devd the ability to
journal writes to blocks. As I debugged that I added a bunch of little
quality of life fixes and started adding tracing to the single threaded
runtime.
Together with your commits it's a big chunk of work :). I did only very
light testing so there's probably a bunch of bugs to shake out.
I should mention that devd now does expect to find blocks in the device
as it starts up. There's a format-device command in the cli to prepare
the device for devd.
Exciting!
- z
More information about the ngnfs-devel
mailing list