[PATCH 08/14] Add ngnfs_dir_get_dirent() and debugfs lookup command

Zach Brown zab at zabbo.net
Fri Feb 28 14:23:55 PST 2025


On Thu, Feb 27, 2025 at 08:24:59PM +0100, Valerie Aurora wrote:

> Oops, already found a bug - this and lookup_dirent() need a:
> 
>         if (da->dent.ino == 0)
>                 ret = -ENOENT;
> 
>         return ret;
> 
> And the null test in fill_lookup_rd() needs to go away. I was mixing
> this up with the ngnfs_btree_write_iter which will call the iter func
> with a null item if the item doesn't exist. Will resend!

Indeed, yeah.  Mapping the possible item populations to the intent of
the iterators is always something we're going to have to keep a sharp
eye on.

More notes on the rest of the patches incoming!

- z



More information about the ngnfs-devel mailing list