[PATCH 00/23] Implement basic file system operations

Zach Brown zab at zabbo.net
Wed Apr 9 11:50:58 PDT 2025


On Fri, Apr 04, 2025 at 08:45:16PM +0200, Valerie Aurora wrote:
> This patch series implements most of the remaining basic file system
> operations:

This is great stuff!

[...]

> This series should address 100% of the comments from the last code
> review; if it's not in here, that's my mistake. rename() and
> setxattr() replace now use the btree replace operation. 

We'll discuss it in the first patch that uses it, but I thought I'd
mention it here too: that btree replace operation isn't implemented.
I'll be honest, I was a bit surprised when you mentioned it.  I didn't
think it ended up in the code.  And then I saw that I had leaked out a
lingering reference to an intent to do it in some version of the code in
that header comment :).  I think it's fixable, and worth it.  I can
throw a patch together or you can take a swing, either's fine with me.

> As usual, take the patches you like and I'll fix up the rest!

Sounds good!  I'm merging the early patches that don't have conflicts
with the patches that need work:

  a1abb8f Add brief instructions on how to run ngnfs
  7d49ecc Send quit signal to process, not process group
  3b68714 Improve naming of dtype code

> particular, the hack for client disconnect can live in my branch until
> I get mapd doing this correctly.

Agreed :).

per-patch emails incoming..

- z



More information about the ngnfs-devel mailing list