[PATCH 21/23] Add ngnfs_xattr_list() and debugfs command

Valerie Aurora val at versity.com
Tue Apr 8 11:43:33 PDT 2025


On Sun, Apr 6, 2025 at 7:11 AM Auke Kok <auke.kok at versity.com> wrote:
>
> On Fri, Apr 4, 2025 at 11:48 AM Valerie Aurora <val at versity.com> wrote:
>
> > +       memcpy(la->buf + la->used, xattr->name, xattr->name_len);
> > +       memset(la->buf + la->used + xattr->name_len + 1, 0, 1);
>
> This isn't right... it should be:
>
> +       memset(la->buf + la->used + xattr->name_len, 0, 1);
>
> e.g. if strlen("name") == 4, the first char "n" sits at [0], so the
> "e" sits at [3] and therefore [4] needs to be zeroed.

Thank you, fixed!

Valerie



More information about the ngnfs-devel mailing list