[PATCH] maple_tree: use KMEM_CACHE to create maple_node caches

Matthew Wilcox willy at infradead.org
Mon Nov 4 05:27:01 PST 2024


On Mon, Nov 04, 2024 at 02:16:17PM +0800, Ke Sun wrote:
> Use the KMEM_CACHE() macro instead of kmem_cache_create() to simplify
> the creation of SLAB caches.

Did you even test this?  It is REQUIRED that maple_node be aligned to
its size (eg 256 bytes) as the bottom bits of pointers to nodes are used
for other purposes.  KMEM_CACHE() does not give us this guarantee.

NACK.



More information about the maple-tree mailing list