[PATCH v2] spi: bcm2835: Convert to platform remove callback returning void

Florian Fainelli f.fainelli at gmail.com
Thu Mar 30 16:22:49 PDT 2023


On 3/30/23 14:10, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Convert this driver from always returning zero in the remove callback to
> the void returning variant.
> 
> Now that bcm2835_spi_remove returns no error code any more,
> bcm2835_spi_shutdown() does the same thing as bcm2835_spi_remove(). So
> drop the shutdown function and use bcm2835_spi_remove() as .shutdown
> callback.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Acked-by: Florian Fainelli <f.fainelli at gmail.com>
-- 
Florian




More information about the linux-rpi-kernel mailing list