[PATCH] staging: vchiq_arm.c: Declare vchiq_platform_init as static
Gaurav Pathak
gauravpathak129 at gmail.com
Wed Jan 11 01:25:29 PST 2023
Hi Greg,
After submitting the patch, I realized this is the duplicate patch of https://www.spinics.net/lists/arm-kernel/msg976512.html
I am in the process of reproducing the issue reported by kernel test robot in the original patch submission.
If I am successful, I will try to fix other warnings.
Best,
Gaurav
On Wed, Jan 11, 2023 at 10:00:37AM +0100, Greg KH wrote:
> On Wed, Jan 11, 2023 at 01:31:24PM +0530, Gaurav Pathak wrote:
> > Modified vchiq_platform_init() as static to fix sparse warning
> > > warning: symbol 'vchiq_platform_init' was not declared. Should it be
> > > static?
>
> Put the warning line all on one line, no need to wrap that.
>
> > Signed-off-by: Gaurav Pathak <gauravpathak129 at gmail.com>
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > index dc33490ba7fb..ffa517077b80 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> > @@ -462,7 +462,7 @@ free_pagelist(struct vchiq_instance *instance, struct vchiq_pagelist_info *pagel
> > cleanup_pagelistinfo(instance, pagelistinfo);
> > }
> >
> > -int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> > +static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state *state)
> > {
> > struct device *dev = &pdev->dev;
> > struct vchiq_drvdata *drvdata = platform_get_drvdata(pdev);
> > --
> > 2.39.0
> >
> >
>
> What changed to enable this version of the patch to work properly
> compared to the previous submissions that broke the build? Did you test
> this and it now works properly?
>
> thanks,
>
> greg k-h
More information about the linux-rpi-kernel
mailing list