[PATCH] thermal: use upstream bcm2835 thermal driver for arm64

[Stefan Wahren]

Hi Allen,

> Allen Wild <allenwild93 at gmail.com> hat am 2. September 2017 um 05:29 geschrieben:
> 
> 
> Eric and Stefan,
> 
> Thanks for your comments. I did send a different patch to the linux-pm
> list without the bcmrpi3_defconfig changes; I'll send a new version of
> that incorporating your suggestions and CC this list.

i see the new version. Unfortunately you missed Eric's note about running scripts/get_maintainers.pl on your patch. Please always CC to the relevant maintainers (Zhang and Eduardo). In this case a simple resend ([PATCH RESEND]) without increasing version is okay.

> 
> >please use branch next from git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git as base for your patch
> I'm working on this, but have to cherry-pick 0fe4d2181cc ("ARM: dts:
> bcm283x: Add CPU thermal zone with 1 trip point") and 4ae6f954b96
> ("ARM64: dts: bcm2837: Define CPU thermal coefficients") from the
> mainline master branch in order to get the bcm2835 thermal driver to
> load correctly. I hope this isn't an issue.

This is no problem.

Stefan

> 
> Thanks,
> Allen
> 
> On Thu, Aug 31, 2017 at 7:29 AM, Stefan Wahren <stefan.wahren at i2se.com> wrote:
> > Hi Allen,
> >
> >
> >
> > Am 31.08.2017 um 06:19 schrieb Eric Anholt:
> >>
> >> Allen Wild <allenwild93 at gmail.com> writes:
> >>
> >>> The downstream bcm2835-thermal driver (enabled with THERMAL_BCM2835)
> >>> doesn't work on the Pi3 in 64 bit mode, but the upstream driver (enabled
> >>> with BCM2835_THERMAL) can't be enabled for arm64 since the Broadcom
> >>> Kconfig menu depends on ARCH_BCM which is only for 32-bit ARM.
> >>>
> >>> This patch enables the Broadcom thermal drivers Kconfigs for
> >>> ARCH_BCM2835 and updates the bcmrpi3_defconfig to use the upstream
> >>> bcm2835 thermal driver.
> >>
> >> This submission probably won't go anywhere, since it's against the
> >> downstream tree and they're not really watching this list.
> >>
> >> If you'd like to send a pair of patches upstream, one to the thermal
> >> subsystem for the Kconfig, and one to ARM for the upstream arm64
> >> defconfig, that would be helpful.  Be sure to use
> >> scripts/get_maintainers.pl to figure out who you need to Cc, and see
> >> Documentation/SubmittingPatches for general requirements
> >> (signed-off-by).
> >
> >
> > thanks for your patch. But as Eric already pointed out this needs some
> > adjustment, before it's merged by the thermal guys.
> >
> > Additionally here some hints:
> >
> > * please use branch next from
> > git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git
> > as base for your patch
> > * paraphrase the commit message that your patch fixes the config regression
> > which was caused by moving the bcm2835 thermal driver into the broadcom
> > directory
> >   (wording upstream and downstream isn't relevant in this case and confuses
> > more that it helps)
> > * drop the bcmrpi3_defconfig stuff because it doesn't exists in mainline
> > kernel
> > * as i mentioned in [1] this commit fixes a regression, so please add the
> > following tag
> >
> > Fixes: 6892cf07e733 ("thermal: bcm2835: move to the broadcom subdirectory")
> >
> > Thanks
> > Stefan
> >
> > [1] - https://github.com/raspberrypi/linux/issues/2136
> >