[PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI

Andy Shevchenko andriy.shevchenko at linux.intel.com
Wed Jun 28 05:01:33 PDT 2017


On Wed, 2017-06-28 at 12:57 +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote:
> > Signed-off-by: Phil Elwell <phil at raspberrypi.org>
> > Acked-by: Eric Anholt <eric at anholt.net>
> > Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> > Changes in v2:
> >  Add review tags.
> 
> nitpick: The order of lines in the Sob area matter and you should add
> your Sob at the end. So as it was you adding the ack by Eric and Andy,
> it should look as follows:
> 
> 	Acked-by: Eric Anholt <eric at anholt.net>
> 	Acked-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> 	Signed-off-by: Phil Elwell <phil at raspberrypi.org>
> 
> . Note that this comment is very picky, quite some people don't get it
> right and I never saw a maintainer refuse a patch because of this. So
> this probably doesn't warrant a v3 :-)

Yeah, it's easily learned when one is using

% git commit -s [--amend]

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy



More information about the linux-rpi-kernel mailing list