[PATCH V2 0/3] Add vchi_queue_kernel_message and vchi_queue_user_message

Michael Zoran mzoran at crowfest.net
Wed Jan 25 05:41:50 PST 2017


On Wed, 2017-01-25 at 14:33 +0100, Greg KH wrote:
> On Wed, Jan 25, 2017 at 05:27:14AM -0800, Michael Zoran wrote:
> > On Wed, 2017-01-25 at 16:14 +0300, Dan Carpenter wrote:
> > > On Wed, Jan 25, 2017 at 04:33:46AM -0800, Michael Zoran wrote:
> > > > Just for clarity, when you mean staging code? Are you talking
> > > > about
> > > > the
> > > > entire vc04_services driver or are we talking about the
> > > > vchi_msg_queue
> > > > function?  
> > > > 
> > > > At this point, vc04_services isn't used by anything in the tree
> > > > at
> > > > all.
> > > >  So if you want all the unused code deleted, well that sounds
> > > > to me
> > > > like you are talking about the whole driver.
> > > 
> > > Yep.  Let's either merge the rest of the code or delete the
> > > driver.
> > > What we have now doesn't work.
> > > 
> > 
> > That's Greg and Eric's decision.  
> > 
> > The vc04_services was already checked into staging when I was asked
> > to
> > submit some ARM64 patches to remove some compiler warnings. My goal
> > has
> > always been simply to get ARM64 to work, and I can probably
> > accomplish
> > that by submitting changes to the RPI specific tree.
> > 
> > I'm just saying that IF the decision was made to continue
> > upstreaming
> > these drivers, then I'm willing to continue helping by submitting
> > improvements.
> 
> Either they should be merged, or these apis and structures will be
> deleted from the in-kernel code, it can't stay as-is.
> 
> thanks,
> 
> greg k-h

Again, that's not my decision.  I can go either way.  But if the
decision was made to delete it, I think the 4.10 version should also be
deleted because the same logic applies.  Nothing uses it 4.10 either
and 4.10 is still an RC.







More information about the linux-rpi-kernel mailing list