[PATCH 1/3] staging: vc04_services: Create new CONFIG_VIDEOCORE setting for VideoCore services.

Greg KH gregkh at linuxfoundation.org
Tue Feb 28 12:26:09 PST 2017


On Tue, Feb 28, 2017 at 11:43:16AM -0800, Michael Zoran wrote:
> On Tue, 2017-02-28 at 20:19 +0100, Greg KH wrote:
> > On Tue, Feb 28, 2017 at 10:49:35AM -0800, Michael Zoran wrote:
> > > Create a new config for Broadcom VideoCore services.
> > > 
> > > Signed-off-by: Michael Zoran <mzoran at crowfest.net>
> > > ---
> > >  drivers/staging/vc04_services/Kconfig | 15 +++++++++++----
> > >  1 file changed, 11 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/drivers/staging/vc04_services/Kconfig
> > > b/drivers/staging/vc04_services/Kconfig
> > > index 3b576b0b49ae..08e46a91d365 100644
> > > --- a/drivers/staging/vc04_services/Kconfig
> > > +++ b/drivers/staging/vc04_services/Kconfig
> > > @@ -1,16 +1,23 @@
> > > -menuconfig BCM2835_VCHIQ
> > > -	tristate "Videocore VCHIQ"
> > > +menuconfig VIDEOCORE
> > 
> > How about BCM_VIDEOCORE?  "CONFIG_VIDEOCORE" really is generic, the
> > V4L
> > developers are going to get mad if they see this :)
> > 
> > thanks,
> > 
> > greg k-h
> 
> Sure no problem.  I'll change it to BCM_VIDEOCORE.
> 
> Also, I'm not sure if I need the word "services" in the title
> description or not.   I'm thinking eventually this stuff is going to
> get moved somewhere else like Drivers/Firmware at which point that
> would be implied.  

It's ok, people don't read it very closely :)

thanks,

greg k-h



More information about the linux-rpi-kernel mailing list