[PATCH V2] staging: vchiq_2835_arm: Make cache-line-size a required DT property

Stefan Wahren stefan.wahren at i2se.com
Tue Feb 21 08:06:43 PST 2017


Am 18.02.2017 um 12:22 schrieb Michael Zoran:
> The original github source allowed for the cache-line-size property
> to be missing.  Since recent firmwares also require this property,
> it makes sense to always require it in the driver as well.
>
> If the cache-line-size property is missing, then the driver probe
> should fail as no dev since the kernel and dt may be out of sync.
> The fix is to add a check for the return value of of_property_read_u32.
>
> Changes V2:
> 	1. Add error message if cache-line-size is missing.
> 	2. Simple check for non-zero return value from
> 	   of_property_read_u32.
>
> Signed-off-by: Michael Zoran <mzoran at crowfest.net>

Acked-by: Stefan Wahren <stefan.wahren at i2se.com>



More information about the linux-rpi-kernel mailing list