[patch] Staging: bcm2835-audio: && vs & typo

Dan Carpenter dan.carpenter at oracle.com
Tue Feb 14 15:10:44 PST 2017


We intended to mask away the upper bits but there is a "&&" vs "&" typo
so it's broken.

Fixes: 23b028c871e1 ("staging: bcm2835-audio: initial staging submission")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/staging/bcm2835-audio/bcm2835-ctl.c b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
index bfb7e9f74176..a4ffa1bf53e5 100644
--- a/drivers/staging/bcm2835-audio/bcm2835-ctl.c
+++ b/drivers/staging/bcm2835-audio/bcm2835-ctl.c
@@ -209,7 +209,7 @@ static int snd_bcm2835_spdif_default_get(struct snd_kcontrol *kcontrol,
 
 	for (i = 0; i < 4; i++)
 		ucontrol->value.iec958.status[i] =
-		(chip->spdif_status >> (i * 8)) && 0xff;
+			(chip->spdif_status >> (i * 8)) & 0xff;
 
 	mutex_unlock(&chip->audio_mutex);
 	return 0;



More information about the linux-rpi-kernel mailing list