[PATCH 0/6] mmc: bcm2835: third cleanup for sdhost driver
Stefan Wahren
stefan.wahren at i2se.com
Thu Feb 16 13:01:35 PST 2017
> Gerd Hoffmann <kraxel at redhat.com> hat am 16. Februar 2017 um 18:00 geschrieben:
>
>
> On Sa, 2017-02-11 at 22:48 +0000, Stefan Wahren wrote:
> > Hi Gerd,
> >
> > i still found some minor issues. Please squash them in your repo if you're
> > fine with them.
> >
> > Regards
> >
> > Stefan Wahren (6):
> > mmc: bcm2835: replace pio_limit with define
> > mmc: bcm2835: Increase max_blk_size to 1024
> > mmc: bcm2835: make internal functions static
> > mmc: bcm2835: reduce variable scope within bcm2835_transfer_block_pio
> > mmc: bcm2835: simplify burst words calculation
> > mmc: bcm2835: remove unnecessary debug messages
> >
> > drivers/mmc/host/bcm2835.c | 67 +++++++++-----------------------------------
> > 1 file changed, 13 insertions(+), 54 deletions(-)
>
> Applied, pushed as bcm2837-sdhost-cleanup, with the dma channel fixes on
> top. Survived basic boot test. I'll go test this a bit more tomorrow,
> then squash the fixes and post a new series.
Great. I noticed a nit with "mmc: bcm2835: add sdhost controller to devicetree".
All nodes with a reg should sorted by register address. So sdhost should be placed between uart0: serial at 7e201000 and i2s: i2s at 7e203000.
Thanks
Stefan
>
> thanks,
> Gerd
>
More information about the linux-rpi-kernel
mailing list