[PATCH 6/6] mmc: bcm2835: remove unnecessary debug messages

Stefan Wahren stefan.wahren at i2se.com
Sat Feb 11 14:48:36 PST 2017


Signed-off-by: Stefan Wahren <stefan.wahren at i2se.com>
---
 drivers/mmc/host/bcm2835.c |   39 ---------------------------------------
 1 file changed, 39 deletions(-)

diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
index 4a04918..f34213d 100644
--- a/drivers/mmc/host/bcm2835.c
+++ b/drivers/mmc/host/bcm2835.c
@@ -466,8 +466,6 @@ void bcm2835_prepare_dma(struct bcm2835_host *host, struct mmc_data *data)
 	struct dma_async_tx_descriptor *desc = NULL;
 	struct dma_chan *dma_chan;
 
-	dev_dbg(&host->pdev->dev, "bcm2835_prepare_dma()\n");
-
 	if (data->flags & MMC_DATA_READ) {
 		dma_chan = host->dma_chan_rx;
 		dir_data = DMA_FROM_DEVICE;
@@ -639,17 +637,6 @@ bool bcm2835_send_command(struct bcm2835_host *host, struct mmc_command *cmd)
 
 	WARN_ON(host->cmd);
 
-	if (cmd->data) {
-		dev_dbg(dev, "send_command %d 0x%x (flags 0x%x) - %s %d*%d\n",
-			cmd->opcode, cmd->arg, cmd->flags,
-			(cmd->data->flags & MMC_DATA_READ) ?
-			"read" : "write", cmd->data->blocks,
-			cmd->data->blksz);
-	} else {
-		dev_dbg(dev, "send_command %d 0x%x (flags 0x%x)\n",
-			cmd->opcode, cmd->arg, cmd->flags);
-	}
-
 	sdcmd = bcm2835_read_wait_sdcmd(host, 100, false);
 	if (sdcmd & SDCMD_NEW_FLAG) {
 		dev_err(dev, "previous command never completed.\n");
@@ -718,9 +705,6 @@ static void bcm2835_transfer_complete(struct bcm2835_host *host)
 	data = host->data;
 	host->data = NULL;
 
-	dev_dbg(&host->pdev->dev, "transfer_complete(error %d, stop %d)\n",
-		data->error, data->stop ? 1 : 0);
-
 	/* Need to send CMD12 if -
 	 * a) open-ended multiblock transfer (no CMD23)
 	 * b) error in multiblock transfer
@@ -744,9 +728,6 @@ static void bcm2835_finish_data(struct bcm2835_host *host)
 
 	data = host->data;
 
-	dev_dbg(dev, "finish_data(error %d, stop %d, sbc %d)\n",
-		data->error, data->stop ? 1 : 0, host->mrq->sbc ? 1 : 0);
-
 	host->hcfg &= ~(SDHCFG_DATA_IRPT_EN | SDHCFG_BLOCK_IRPT_EN);
 	writel(host->hcfg, host->ioaddr + SDHCFG);
 
@@ -772,8 +753,6 @@ static void bcm2835_finish_command(struct bcm2835_host *host)
 	struct mmc_command *cmd = host->cmd;
 	u32 sdcmd;
 
-	dev_dbg(dev, "finish_command(%08x)\n", readl(host->ioaddr + SDCMD));
-
 	sdcmd = bcm2835_read_wait_sdcmd(host, 100, true);
 
 	/* Check for errors */
@@ -812,13 +791,8 @@ static void bcm2835_finish_command(struct bcm2835_host *host)
 				cmd->resp[3 - i] =
 					readl(host->ioaddr + SDRSP0 + i * 4);
 			}
-
-			dev_dbg(dev, "finish_command %08x %08x %08x %08x\n",
-				cmd->resp[0], cmd->resp[1],
-				cmd->resp[2], cmd->resp[3]);
 		} else {
 			cmd->resp[0] = readl(host->ioaddr + SDRSP0);
-			dev_dbg(dev, "finish_command %08x\n", cmd->resp[0]);
 		}
 	}
 
@@ -870,7 +844,6 @@ static void bcm2835_timeout(struct work_struct *work)
 			else
 				host->mrq->cmd->error = -ETIMEDOUT;
 
-			dev_dbg(dev, "timeout_timer tasklet_schedule\n");
 			bcm2835_finish_request(host);
 		}
 	}
@@ -1408,11 +1381,6 @@ static int bcm2835_probe(struct platform_device *pdev)
 
 	host->phys_addr = be32_to_cpup(regaddr_p);
 
-	dev_dbg(dev, " - ioaddr %lx, iomem->start %lx, phys_addr %lx\n",
-		(unsigned long)host->ioaddr,
-		(unsigned long)iomem->start,
-		(unsigned long)host->phys_addr);
-
 	host->dma_chan = NULL;
 	host->dma_desc = NULL;
 
@@ -1436,10 +1404,6 @@ static int bcm2835_probe(struct platform_device *pdev)
 		goto err;
 	}
 
-	dev_dbg(dev, " - max_clk %u, irq %d\n",
-		host->max_clk,
-		(int)host->irq);
-
 	ret = mmc_of_parse(mmc);
 	if (ret)
 		goto err;
@@ -1465,8 +1429,6 @@ static int bcm2835_remove(struct platform_device *pdev)
 {
 	struct bcm2835_host *host = platform_get_drvdata(pdev);
 
-	dev_dbg(&pdev->dev, "%s\n", __func__);
-
 	mmc_remove_host(host->mmc);
 
 	writel(SDVDD_POWER_OFF, host->ioaddr + SDVDD);
@@ -1479,7 +1441,6 @@ static int bcm2835_remove(struct platform_device *pdev)
 	mmc_free_host(host->mmc);
 	platform_set_drvdata(pdev, NULL);
 
-	dev_dbg(&pdev->dev, "%s - OK\n", __func__);
 	return 0;
 }
 
-- 
1.7.9.5




More information about the linux-rpi-kernel mailing list