[PATCH 0/6] vc04_services: Make it work on arm64

Greg KH gregkh at linuxfoundation.org
Thu Oct 20 01:40:36 PDT 2016


On Wed, Oct 19, 2016 at 03:57:46PM -0700, mzoran at crowfest.net wrote:
> From: Michael Zoran <mzoran at crowfest.net>
> 
> This is a revised version of the last patch set.

"last" is vague, in the future, please version your patch sets.  The
file, Documentation/SubmittingPatches goes into the details of how to do
that properly.

Also, you forgot to cc: the relevant people and mailing list
(driverdevel), please use scripts/get_maintainer.pl to determine that in
the future.  I'll queue these up soon, but please be more careful next
time.

> #1 includes the dsb(sy) change previously in #4
> #6 contains the changes to remove warnings that was accidently
> included in #4.
> #4 has the changes forked into #1 and #6 removed.
> 
> With the exception of change #4, most of the changes should be
> safe and have very little performance impact.
> 
> #4 does have a some performance impact, so it may be best 
> to commit #1-3 and #5-6 independently.  I am working on some 
> improvements for #4

You should put this warning in patch 4 so I am sure to see it :)

> Here are some results of performance tests with and without #4
> 
> Test                            dmac_map_area           dma_map_page
> vchiq_test -b 4 10000           51us/iter               76us/iter
> vchiq_test -b 8 10000           70us/iter               82us/iter
> vchiq_test -b 16 10000          94us/iter               118us/iter
> vchiq_test -b 32 10000          146us/iter              173us/iter
> vchiq_test -b 64 10000          263us/iter              328us/iter
> vchiq_test -b 128 10000         529us/iter              631us/iter
> vchiq_test -b 256 10000         2285us/iter             2275us/iter
> vchiq_test -b 512 10000         4372us/iter             4616us/iter

Same with this, it needs to go into patch 4.  I'll drop that patch from
my queue now so I don't accidentally apply it.

thanks,

greg k-h



More information about the linux-rpi-kernel mailing list