[PATCH V2 3/8] dmaengine: bcm2835: use shared interrupt for channel 11 to 14.

Vinod Koul vinod.koul at intel.com
Wed Jan 13 04:26:21 PST 2016


On Thu, Jan 07, 2016 at 05:33:01PM +0000, kernel at martin.sperl.org wrote:
> @@ -638,13 +666,21 @@ static int bcm2835_dma_probe(struct platform_device *pdev)
>  		goto err_no_dma;
>  	}
>  
> -	for (i = 0; i < pdev->num_resources; i++) {
> -		irq = platform_get_irq(pdev, i);
> +	for (i = 0; i <= BCM2835_DMA_MAX_CHANNEL_NUMBER; i++) {
> +		if (BCM2835_DMA_IRQ_SHARED_MASK & BIT(i)) {

Ideally this should be done thru DT data and not hard coded in kernel. I
dont think this assumption will hold good for next gen of this device, so
better to get this from DT!

-- 
~Vinod



More information about the linux-rpi-kernel mailing list