usb: dwc2: regression on bcm2835 after commit 09c96980dc72

[Stefan Wahren]

Hi Remi,

> Remi Pommarel <repk at triplefau.lt> hat am 2. Januar 2016 um 14:55 geschrieben:
>
>
> Hi Stefan, Hi John,
>
> On Mon, Dec 28, 2015 at 3:16:47AM -0800, Stefan Wharen wrote:
...
>
> I came up with the same patch, but it does not seem to fix everything. Indeed
> 263b7fb557f797d9d4d1dcf93fb6bb2efc3f1d46 (previous patch in patchset) seems
> to break USB ethernet also.

yes i can confirm that this patch is also a regression. I get the following

256 invalid for host_nperio_tx_fifo_size. Check HW configuration.
512 invalid for host_perio_tx_fifo_size. Check HW configuration.

without changing any parameter above.

>
> My guess is that bcm2835 still need dwc2_core_reset_and_force_dr_mode()
> before dwc2_get_hwparams().

I agree. IMHO this patch should be reverted.

>
> Do you have any idea ?
>
> Regards
>
> --
> Remi