[PATCH] clk: bcm: Fix 'maybe-uninitialized' warning in bcm2835_clock_choose_div_and_prate()

Arnd Bergmann arnd at arndb.de
Mon Dec 12 00:35:15 PST 2016


On Monday, December 12, 2016 9:31:30 AM CET Boris Brezillon wrote:
> On Mon, 12 Dec 2016 09:12:36 +0100
> Arnd Bergmann <arnd at arndb.de> wrote:
> 
> > On Monday, December 12, 2016 9:00:53 AM CET Boris Brezillon wrote:
> > > best_rate is reported as potentially uninitialized by gcc.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> > > Fixes: 155e8b3b0ee3 ("clk: bcm: Support rate change propagation on bcm2835 clocks")
> > > Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>  
> > 
> > I wonder why I didn't get that. Which compiler version did you use?
> > 
> 
> In case you're interested, my gcc [1] failed to detect it as well, and
> this is not the first time it happens :-/.
> 
> [1]gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609

No, I see it now with gcc-7, it only just turned up in linux-next.

I ran into it right away with an allmodconfig build. You were
probably testing based on an earlier v4.9-rc release that had
the warning globally disabled.

	Arnd



More information about the linux-rpi-kernel mailing list